-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add service renaming #1580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you extend one of the existing tests to show this is working as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the following generated doc in the provided diff:
// NewTopicAdminClient creates a new publisher client based on gRPC.
Note: "new publisher client".
This seems acceptable to me for most cases, but I suppose it could result in some confusion depending on the original name.
Yes, that was a one off where the code calls |
I still found one usage in the diff, if you want to look into it:
|
This PR adds support for service name overriding (renaming).
This PR cannot be merged until the new client.proto changes land to support therenamed_services
field and the actual code ingenerator.getServiceNameOverride
is uncommented.Pieces of the generator that are currently not changed by service renaming:
Diff for Pub/Sub is viewable here: https://github.com/googleapis/google-cloud-go/compare/main...hongalex:google-cloud-go:new-gapic-diff?expand=1
Fixes #1581