Fix incorrect/missing IR semantics documentation #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds missing `nand` and `nor` operations and clarifies their behaviour. - Adds missing reduction operations. - Correct typing of `eq` and `ne` operands: They can by any type, not just `bits`
meheff
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
nandandnoroperations and clarifies their behavior.Adds missing reduction operations.
Correct typing of
eqandneoperands: They can be any type, not justbitsPlease especially check the following, as far as I can tell this is the behavior of the IR interpreter:
For reduction ops:
Cheers!