Fetch execution count per node for async run #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
### Why This will give users more accurate view of the graph of an async run by exposing the actual number of executions per node for async run without increasing the overall latency to render the page. Note that displaying the number of artifacts is much more expensive as it requires us to fetch events, which takes time that is not much different from fetching the whole data. ### Testing * Screencast: https://screencast.googleplex.com/cast/NDk2Mjc1NDE0MTA5Mzg4OHw2MWRlOGVlYS0zZA PiperOrigin-RevId: 708111788
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch execution count per node for async run
Why
This will give users more accurate view of the graph of an async run by exposing the actual number of executions per node for async run without increasing the overall latency to render the page. Note that displaying the number of artifacts is much more expensive as it requires us to fetch events, which takes time that is not much different from fetching the whole data.
Testing