feat: generate uuid V7 base on provided time #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
snaffi
changed the title
rockwotj
reviewed
Jan 29, 2025
| @@ -85,11 +99,11 @@ const nanoPerMilli = 1000000 | |||
| // getV7Time returns the time in milliseconds and nanoseconds / 256. | |||
| // The returned (milli << 12 + seq) is guaranteed to be greater than | |||
| // (milli << 12 + seq) returned by any previous call to getV7Time. | |||
| func getV7Time() (milli, seq int64) { | |||
| func getV7Time(timeFunc func() time.Time) (milli, seq int64) { | |||
There was a problem hiding this comment.
Due to the behavior later in this function with lastV7time I don't think we want that when using a custom timestamp. Basically if you pass in a future time, then a past time, the past time will get reset to be in the future. I opened #182 that doesn't have this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.