Update to the windows deployment script #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged 'sed' function to correctly update timesketch.conf OPENSEARCH_HOST and OPENSEARCH_PORT paramters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jkppr
changed the title
jkppr
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the deploy_timesketch.ps1 script to include a cryptographically Windows CRNG function for generating the POSTGRES_PASSWORD and SECRET_KEY variables. It also corrects the 'sed' (Get-Content) lines to update OPENSEARCH_HOST and OPENSEARCH_PORT in the timesketch.conf file instead of ELASTIC_HOST and ELASTIC_PORT variables which have changed in the current timesketch.conf file. The incorrectly named variables were causing the installation to fail on Windows without manual fixes.
Checks
Closing issues
closes #2986
closes #2985