Replace badly supported u128 TraceId with byte array #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr! What about keeping the u128 but having custom (de)serialize fns using the |
Kouzukii
force-pushed
the
replace_u128_traceid
branch
from
b51126c to
a3057cf
Compare
tikue
requested changes
Mar 30, 2021
Kouzukii
force-pushed
the
replace_u128_traceid
branch
from
a3057cf to
d5e6f30
Compare
tikue
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary serde codecs such as CBOR do not support Rusts u128/i128 datatypes (pyfisch/cbor#140).
In order to be able to use these with tarpc, the u128 TraceId could be made serializable using a 16 byte array as the internal representation.