Skip to content
This repository has been archived by the owner on Jan 31, 2025. It is now read-only.

Disable some tests on Windows #4505

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Disable some tests on Windows #4505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02643be
Disable some tests on Windows
florian-kuebler Nov 29, 2022
bc14380
add todo
florian-kuebler Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/ObjectUtils/ElfFileTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,10 @@ TEST(ElfFile, GetDeclarationLocationOfFunction) {
}

TEST(ElfFile, GetDeclarationLocationOfFunctionLibc) {
// TODO(https://github.com/google/orbit/issues/4502): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
const std::filesystem::path file_path = orbit_test::GetTestdataDir() / "libc.debug";

auto program = CreateElfFile(file_path);
Expand All @@ -611,6 +615,10 @@ TEST(ElfFile, GetDeclarationLocationOfFunctionLibc) {
}

TEST(ElfFile, GetLocationOfFunctionLibc) {
// TODO(https://github.com/google/orbit/issues/4502): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
const std::filesystem::path file_path = orbit_test::GetTestdataDir() / "libc.debug";

auto program = CreateElfFile(file_path);
Expand All @@ -627,6 +635,10 @@ TEST(ElfFile, GetLocationOfFunctionLibc) {
}

TEST(ElfFile, GetLocationOfFunctionNoSubroutine) {
// TODO(https://github.com/google/orbit/issues/4502): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
const std::filesystem::path file_path = orbit_test::GetTestdataDir() / "libc.debug";

auto program = CreateElfFile(file_path);
Expand Down
4 changes: 4 additions & 0 deletions src/WindowsUtils/ProcessLauncherTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ TEST(ProcessLauncher, LaunchProcess) {
}

TEST(ProcessLauncher, LaunchSuspendResumeProcess) {
// TODO(https://github.com/google/orbit/issues/4503): Enable test again.
#ifdef _WIN32
GTEST_SKIP();
#endif
ProcessLauncher launcher;
auto launch_result =
launcher.LaunchProcess(GetTestExecutablePath(), /*working_directory=*/"", /*arguments=*/"",
Expand Down