Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to build protobuf v30 with Bazel+MSVC #1178

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

yukawa
Copy link
Collaborator

@yukawa yukawa commented Feb 9, 2025

Description

As seen in the following thread, the protobuf team is planning to stop supporting the combination of Bazel and cl.exe due to well-known its path length limitation.

As a preparation before switching to protobuf v30 (#1177), let's explicitly add a command line option as explained to continue using this combination as a short term solution.

This commit should have no impact on probobuf v29.x.

Issue IDs

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: Windows 11 24H2
  • Steps:
    1. Modify MODULE.bazel to use protobuf v30.rc1
    2. Apply this patch.
    3. Confirm you can still build Mozc for Windows with bazel.

Additional context

Add any other context about the pull request here.

As seen in the following thread, the protobuf team is planning to stop
supporting the combination of Bazel and cl.exe due to well-known its
path length limitation.

 * protocolbuffers/protobuf#20085

As a preparation before switching to protobuf v30 (google#1177), let's
explicitly add a commandline option as explained to continue using this
combination as a short term solution.

This commit should have no impact on Probobuf v29.x.
@hiroyuki-komatsu hiroyuki-komatsu merged commit f8bb199 into google:master Feb 12, 2025
1 check passed
@hiroyuki-komatsu
Copy link
Collaborator

We have merged your PR.
Thank you for the contribution.

@yukawa yukawa deleted the issue1177_prep branch February 18, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants