Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update third_party/protobuf to v30.0 #1177

Open
yukawa opened this issue Feb 9, 2025 · 1 comment
Open

Update third_party/protobuf to v30.0 #1177

yukawa opened this issue Feb 9, 2025 · 1 comment

Comments

@yukawa
Copy link
Collaborator

yukawa commented Feb 9, 2025

Description

While protobuf v30.0 is still a release candidate 1, there is an interesting breaking change announced.

This issue is a placeholder for gathering feedback on an upcoming breaking change

Due to persistent issues with MSVC's path length limits, we've decided to drop support for Bazel in 34.0. Starting in 30.0, you will need to explicitly set a flag --define=protobuf_allow_msvc=true to use this combination. Our recommended alternative is clang-cl, which we will officially support going forward.

Version or commit-id

3baa8d8

Additional context

Previous update:
yukawa added a commit to yukawa/mozc that referenced this issue Feb 9, 2025
@yukawa
Enable to build protobuf v30 with Bazel+MSVC
ea73299 
As seen in the following thread, the protobuf team is planning to stop
supporting the combination of Bazel and cl.exe due to well-known its
path length limitation.

 * protocolbuffers/protobuf#20085

As a preparation before switching to protobuf v30 (google#1177), let's
explicitly add a commandline option as explained to continue using this
combination as a short term solution.

This commit should have no impact on Probobuf v29.x.
This was referenced Feb 9, 2025
Merged
Open
hiroyuki-komatsu pushed a commit that referenced this issue Feb 12, 2025
@yukawa
Enable to build protobuf v30 with Bazel+MSVC (#1178)
f8bb199 
As seen in the following thread, the protobuf team is planning to stop
supporting the combination of Bazel and cl.exe due to well-known its
path length limitation.

 * protocolbuffers/protobuf#20085

As a preparation before switching to protobuf v30 (#1177), let's
explicitly add a commandline option as explained to continue using this
combination as a short term solution.

This commit should have no impact on Probobuf v29.x.

PiperOrigin-RevId: 725882774
@yukawa
Copy link
Collaborator Author

yukawa commented Feb 13, 2025

Seems that the protobuf team is planning to start requiring abseil-cpp 20250127 in their 30.x branch.

If it happens, then switching to abseil-cpp 20250127 becomes the blocker of this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yukawa