Add lifecycle parameter to AmbientAware #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kul3r4
approved these changes
Dec 9, 2024
yschimke
added a commit
to yschimke/horologist
that referenced
this pull request
Dec 10, 2024
--------- Co-authored-by: yschimke <[email protected]> (cherry picked from commit 4cceb8d)
4 tasks
yschimke
added a commit
that referenced
this pull request
Dec 10, 2024
* Add lifecycle parameter to AmbientAware (#2481) --------- Co-authored-by: yschimke <[email protected]> (cherry picked from commit 4cceb8d) * Cherry pick #2476 Ceil padding to 1px * Update ScalingLazyColumnDefaults.kt * 🤖 Updates screenshots --------- Co-authored-by: yschimke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This change adds an optional
lifecycleparameter to theAmbientAwarecomposable function, allowing developers to specify a custom lifecycle instead of relying on theLocalLifecycleOwner.This provides more flexibility when using
AmbientAwarein different contexts, such as within individual screens in navigation routes. If not specified, it defaults to the currentLocalLifecycleOwner's lifecycle.WHY
HOW
Checklist 📋