Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.x] cherry pick ambient changes #2477

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Dec 6, 2024

WHAT

#2472

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

This change refactors the `AmbientAware` API to make it more intuitive and easier to use.

The following changes were made:

- The `AmbientAware` composable moves to the screen level
- The `AmbientStateUpdate` class was merged into `AmbientState`.
- The `AmbientState` sealed interface now has a data object `Interactive` and a data class `Ambient` to store AmbientDetails, as well as Inactive.

---------

Co-authored-by: yschimke <[email protected]>
(cherry picked from commit f8ccc68)
)

* Fix: Handle missing AmbientLifecycleObserver in Robolectric

Handles missing AmbientLifecycleObserver in Robolectric tests by catching NoClassDefFoundError and returning null instead of crashing. This allows ambient-aware composables to be tested in Robolectric without requiring a real device or emulator.

---------

Co-authored-by: yschimke <[email protected]>
(cherry picked from commit 6cd025b)
@yschimke yschimke requested a review from kul3r4 December 6, 2024 12:21
@yschimke yschimke marked this pull request as ready for review December 6, 2024 12:56
@yschimke yschimke requested a review from garanj December 6, 2024 12:58
@yschimke yschimke merged commit 306c077 into google:release-0.6.x Dec 6, 2024
6 checks passed
@kul3r4
Copy link
Collaborator

kul3r4 commented Dec 6, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants