Use Roborazzi A11y checks #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the handling of accessibility checks for off-screen elements in the UI tests. It suppresses accessibility errors for elements which are off-screen but are intended to be scrolled on-screen. This improves the accuracy and efficiency of the accessibility tests by ignoring false-positives related to these elements. Additionally, it removes unnecessary custom shadow classes that were previously used for accessibility testing. These shadows caused conflicts and were replaced by existing Roborazzi features. This simplifies the testing setup and relies on external libraries for better maintainability. Finally, it updates the version of the Roborazzi library to bring in the new accessibility checking capabilities. This allows the tests to use newer, more robust and accurate accessibility checking features.
|
|
@garanj landing as test only, will follow up on review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This change updates the handling of accessibility checks for off-screen elements in the UI tests. It suppresses accessibility errors for elements which are off-screen but are intended to be scrolled on-screen.
This improves the accuracy and efficiency of the accessibility tests by ignoring false-positives related to these elements.
Additionally, it removes unnecessary custom shadow classes that were previously used for accessibility testing. These shadows caused conflicts and were replaced by existing Roborazzi features. This simplifies the testing setup and relies on external libraries for better maintainability.
Finally, it updates the version of the Roborazzi library to bring in the new accessibility checking capabilities. This allows the tests to use newer, more robust and accurate accessibility checking features.
WHY
HOW
Checklist 📋