-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wear capabilities to values folder #2388
Conversation
@yschimke I didn't run a test on release target, but maybe we can do that if u want? :) |
docs/datalayer-helpers-guide.md
Outdated
@@ -28,7 +28,7 @@ phone. | |||
|
|||
2. Add the capabilities | |||
|
|||
Add a `wear.xml` file in the `res/raw` folder with the following content. It needs to be | |||
Add a `wear.xml` file in the `res/values` folder with the following content. It needs to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs don't show the two files
res/values - the string-array
res/raw - the tools:keep
Can you split in the docs also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll try to split them up :) Good idea :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this? Now I also added the NB notice to make people see that it is a different folder :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
`res/raw` folder due to https://issuetracker.google.com/issues/348688201
Needs to move down to the next paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes you are right! 🤦 😅 Thanks! Fixing
If you want to add that go for it. It might need a new target to be added to CI workflows. Otherwise I can follow up |
I do wonder whether the keep file if put in a library would also work for other apps using the library? |
Maybe it's worth testing? |
129e4e5
to
e7200fc
Compare
e7200fc
to
b45cf0f
Compare
WHAT
Follow up on #2281 (comment) and move wear file back to values folder
WHY
Due to #2281 (comment)
Checklist 📋