Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wear capabilities to values folder #2388

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

oas004
Copy link
Contributor

@oas004 oas004 commented Sep 13, 2024

WHAT

Follow up on #2281 (comment) and move wear file back to values folder

WHY

Due to #2281 (comment)

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@oas004
Copy link
Contributor Author

oas004 commented Sep 13, 2024

@yschimke I didn't run a test on release target, but maybe we can do that if u want? :)

@@ -28,7 +28,7 @@ phone.

2. Add the capabilities

Add a `wear.xml` file in the `res/raw` folder with the following content. It needs to be
Add a `wear.xml` file in the `res/values` folder with the following content. It needs to be
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs don't show the two files

res/values - the string-array
res/raw - the tools:keep

Can you split in the docs also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll try to split them up :) Good idea :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? Now I also added the NB notice to make people see that it is a different folder :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the

`res/raw` folder due to https://issuetracker.google.com/issues/348688201

Needs to move down to the next paragraph.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes you are right! 🤦 😅 Thanks! Fixing

@yschimke
Copy link
Collaborator

yschimke commented Sep 16, 2024

@yschimke I didn't run a test on release target, but maybe we can do that if u want? :)

If you want to add that go for it. It might need a new target to be added to CI workflows. Otherwise I can follow up

@yschimke
Copy link
Collaborator

I do wonder whether the keep file if put in a library would also work for other apps using the library?

@oas004
Copy link
Contributor Author

oas004 commented Sep 16, 2024

I do wonder whether the keep file if put in a library would also work for other apps using the library?

Maybe it's worth testing?

@oas004 oas004 force-pushed the mv-wear-capabilities branch from 129e4e5 to e7200fc Compare September 16, 2024 19:43
@oas004 oas004 force-pushed the mv-wear-capabilities branch from e7200fc to b45cf0f Compare September 18, 2024 18:06
@yschimke yschimke merged commit 66ec0b7 into google:main Sep 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants