Fix automatic toolchain downloads again. #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Automatic toolchains downloads aren't necessary for our CI, which pre-downloads the toolchains that it needs. But automatic toolchains downloads remain necessary for local users who don't already have the necessary JDKs downloaded and registered. I had the configuration right initially, and then I broke it in cl/711746683 without noticing because (as a comment in `pom.xml` observes) you don't notice unless you clear out your local Maven configuration before running. (I still haven't done that now, as of this writing, because I'm in the process of using one of the Maven-configured JDKs for something else....) This fix also addresses this warning: ``` [WARNING] Some problems were encountered while building the effective model for com.google.guava:guava:bundle:HEAD-jre-SNAPSHOT [WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.mvnsearch:toolchains-maven-plugin @ com.google.guava:guava-parent:HEAD-jre-SNAPSHOT, /usr/local/google/home/cpovirk/clients/guava-black/guava/pom.xml, line 389, column 17 [WARNING] [WARNING] Some problems were encountered while building the effective model for com.google.guava:guava-parent:pom:HEAD-jre-SNAPSHOT [WARNING] 'build.pluginManagement.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.mvnsearch:toolchains-maven-plugin @ line 389, column 17 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. ``` RELNOTES=n/a PiperOrigin-RevId: 715914892
copybara-service
bot
force-pushed
the
test_715831916
branch
from
8116a38 to
d6ceb21
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ing again. RELNOTES=n/a PiperOrigin-RevId: 715917786
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ing again. RELNOTES=n/a PiperOrigin-RevId: 715917786
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ing again. RELNOTES=n/a PiperOrigin-RevId: 715917786
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ing again. RELNOTES=n/a PiperOrigin-RevId: 715960471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix automatic toolchain downloads again.
Automatic toolchains downloads aren't necessary for our CI, which pre-downloads the toolchains that it needs. But automatic toolchains downloads remain necessary for local users who don't already have the necessary JDKs downloaded and registered.
I had the configuration right initially, and then I broke it in cl/711746683 without noticing because (as a comment in
pom.xmlobserves) you don't notice unless you clear out your local Maven configuration before running. (I still haven't done that now, as of this writing, because I'm in the process of using one of the Maven-configured JDKs for something else....)This fix also addresses this warning:
RELNOTES=n/a