Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code health] Add test coverage for adhoc data submission flow #2980

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Jan 5, 2025

Fixes #2502

This is a no-op change and adds test coverage for data submission flow when LOI isn't provided and needs to be created along with the whole flow (incl. LoiDialogName handling).

Also adds a couple of TODOs for detected code smells.

Increases overall coverage by 1.28%. See codecov reports #2980 (comment).

@anandwana001 @gino-m PTAL?

@auto-assign auto-assign bot requested a review from anandwana001 January 5, 2025 17:28
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.38%. Comparing base (acb6193) to head (a667901).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2980      +/-   ##
============================================
+ Coverage     62.10%   63.38%   +1.28%     
- Complexity     1206     1219      +13     
============================================
  Files           266      266              
  Lines          6434     6438       +4     
  Branches        905      905              
============================================
+ Hits           3996     4081      +85     
+ Misses         1871     1777      -94     
- Partials        567      580      +13     
Files with missing lines Coverage Δ
...nd/domain/usecases/submission/SubmitDataUseCase.kt 86.36% <ø> (+54.54%) ⬆️
...ound/ui/datacollection/components/LoiNameDialog.kt 73.52% <100.00%> (+73.52%) ⬆️
.../datacollection/tasks/point/DropPinTaskFragment.kt 80.00% <ø> (+22.22%) ⬆️
...datacollection/tasks/point/DropPinTaskViewModel.kt 93.93% <ø> (ø)

... and 4 files with indirect coverage changes

@shobhitagarwal1612 shobhitagarwal1612 merged commit 9526646 into master Jan 7, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/test-coverage/adhoc branch January 7, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test coverage] Add unit test for adhoc data submission flow
2 participants