Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaliGemma model Code Correction: Model Name & Documentation Link #544

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

RenuPatelGoogle
Copy link
Contributor

Description of the change

Typo: Fixed the model name in the code - paligemma = keras_hub.models.PaliGemmaCausalLM.from_preset("paligemma_3b_mix_224") from "paligemma_3b_mix_224" to "pali_gemma_3b_mix_224" to correctly load the model.
Broken Link: Updated the URL for "PaliGemma prompt and system instructions" by replacing the existing URL with the correct URL - https://ai.google.dev/gemma/docs/paligemma/prompt-system-instructions/##prompt_task_syntax.

Motivation

Type of change

Choose one: (Bug fix)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

Typo: Fixed the model name in the code - `paligemma = keras_hub.models.PaliGemmaCausalLM.from_preset("paligemma_3b_mix_224")` from "paligemma_3b_mix_224" to "pali_gemma_3b_mix_224" to correctly laod the model.
Broken Link: Updated the URL for "PaliGemma prompt and system instructions" by replacing the existing URL with the  https://ai.google.dev/gemma/docs/paligemma/prompt-system-instructions/##prompt_task_syntax.
@RenuPatelGoogle RenuPatelGoogle requested a review from a team as a code owner December 10, 2024 10:24
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Dec 10, 2024
@RenuPatelGoogle RenuPatelGoogle changed the title PaliGemma Code Correction: Model Name & Documentation Link PaliGemma2 model Code Correction: Model Name & Documentation Link Dec 10, 2024
@RenuPatelGoogle RenuPatelGoogle changed the title PaliGemma2 model Code Correction: Model Name & Documentation Link PaliGemma model Code Correction: Model Name & Documentation Link Dec 10, 2024
Fixed problem with "View on" button from lint report
@joefernandez joefernandez merged commit e8dc8c5 into google:main Dec 12, 2024
4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants