Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected URL path to access the Kaggle Gemma model weights dir #526

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

RenuPatelGoogle
Copy link
Contributor

@RenuPatelGoogle RenuPatelGoogle commented Sep 25, 2024

Description of the change

There was an issue in the document code due to incorrect URL path for Kaggle Gemma-2 weights dir.

I have corrected incorrect URL for accessing the Kaggle Gemma-2 model checkpoint and weight directory from "google/gemma-2-2b/pyTorch/gemma-2-{VARIANT}" to "google/gemma-2/pyTorch/gemma-2-{VARIANT}".

I have updated the URL after verifying on the Kaggle platform and also have successfully implemented and tested in a Colab environment.

Please find the replicated gist here for the same.

Motivation

User-reported an issue on Kaggle for the same -#535372. While investigating the issue,I have found that a URL mismatch was causing this error. Error got resolved after correcting the URL and code run successfully..

Type of change

Code Fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

I have corrected incorrect URL for accessing the Kaggle Gemma-2 model checkpoint and weight directory from "google/gemma-2-2b/pyTorch/gemma-2-{VARIANT}" to "google/gemma-2/pyTorch/gemma-2-{VARIANT}". 

I have updated the URL after verifying on the Kaggle platform and also have successfully implemented and tested in a Colab environment. 

Please find the replicated [gist](https://colab.sandbox.google.com/gist/RenuPatelGoogle/711a744401b32b30048c2f100d0ab7d2/kaggle_gemma2.ipynb) here for the same.
@RenuPatelGoogle RenuPatelGoogle requested a review from a team as a code owner September 25, 2024 18:00
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Sep 25, 2024
@markmcd markmcd merged commit 18817ac into google:main Oct 8, 2024
4 of 5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants