Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distributed_tuning.ipynb #437

Merged
merged 2 commits into from
May 26, 2024
Merged

Update distributed_tuning.ipynb #437

merged 2 commits into from
May 26, 2024

Conversation

windmaple
Copy link
Contributor

Link to Colab tutorial for Gemma distributed finetuning

Description of the change

Originally Colab didn't work for Gemma dist finetuning. But Colab team figured it out and created a copy of the tutorial that works on Colab TPU.

Link to Colab tutorial for Gemma distributed finetuning
@windmaple windmaple requested a review from a team as a code owner May 25, 2024 08:18
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels May 25, 2024
@pcoet
Copy link
Contributor

pcoet commented May 25, 2024

The linter is complaining about the Colab link. It might be a false positive, but we should update the link to not use the Colab sandbox (colab.sandbox.google.com).

@windmaple
Copy link
Contributor Author

Fixed

@pcoet
Copy link
Contributor

pcoet commented May 26, 2024

Thanks. It looks like the notebook on GitHub is not the same one we're opening in Colab, but I'm sure that's for a reason. I'll squash/merge.

@pcoet pcoet merged commit 249a811 into google:main May 26, 2024
3 of 4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 26, 2024
@windmaple
Copy link
Contributor Author

Right. Colab team had to fork it to do some hacking due to its lower version of TPU v2. Kaggle offers TPU v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants