Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package vsix And Add getCommentperfixes Funtion #345

Closed
wants to merge 8 commits into from

Conversation

JasonQWJ
Copy link

@JasonQWJ JasonQWJ commented Apr 3, 2024

Add Package vsix And Add getCommentperfixes Funtion

Description of the change

Add a Launch :Package Extension
Add getCommentperfixes Funtion
Add Menus : Editor Context
Add more Code label And Comment Label

Motivation

Type of change

Feature request

Checklist

  • [-] I have performed a self-review of my code.
  • [-] I have added detailed comments to my code where applicable.
  • [-] I have verified that my change does not break existing code.
  • [-] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [-] I am familiar with the Google Style Guide for the language I have coded in.
  • [-] I have read through the Contributing Guide and signed the Contributor License Agreement.

add getCommentperfixes
@JasonQWJ JasonQWJ requested a review from a team as a code owner April 3, 2024 11:46
Copy link

google-cla bot commented Apr 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Apr 3, 2024
@JasonQWJ JasonQWJ closed this Apr 3, 2024
@JasonQWJ JasonQWJ reopened this Apr 3, 2024
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer and removed status:awaiting review PR awaiting review from a maintainer labels Apr 3, 2024
JasonQWJ and others added 2 commits April 3, 2024 20:06
@markmcd
Copy link
Member

markmcd commented Apr 4, 2024

Thanks for the contribution! Please sign the CLA so we can look at the code.

Without looking at the code it looks like there might be some things you can do first:

  • Can this PR be split up at all? If there's some overarching feature being built that requires each of the changes, then that's OK, but if the changes can be made independently, that makes it easier to review (see our recommendation on small changes).
  • Please make sure you either 1) link to an existing issue/FR or 2) explain why each change is being made - this helps us understand whether the changes are optimal.
  • Don't check in binary files - for something like a vsix file, adding the metadata and build configurations would be OK, but don't include the package. Binaries can't be verified for tampering so can only be shipped by Google.

@markmcd markmcd added status:awaiting user response Awaiting a response from the author and removed status:awaiting review PR awaiting review from a maintainer labels Apr 4, 2024
@JasonQWJ
Copy link
Author

JasonQWJ commented Apr 6, 2024

Thanks for the contribution! Please sign the CLA so we can look at the code.

Without looking at the code it looks like there might be some things you can do first:

  • Can this PR be split up at all? If there's some overarching feature being built that requires each of the changes, then that's OK, but if the changes can be made independently, that makes it easier to review (see our recommendation on small changes).
  • Please make sure you either 1) link to an existing issue/FR or 2) explain why each change is being made - this helps us understand whether the changes are optimal.
  • Don't check in binary files - for something like a vsix file, adding the metadata and build configurations would be OK, but don't include the package. Binaries can't be verified for tampering so can only be shipped by Google.

Dear @markmcd ,

Thank you for your feedback. I have signed the CLA.

This is my first pull request, and I have deleted the binary files. I am not familiar with many of the rules, and it seems that my changes are only for my own needs and do not represent the ideas of others. In the future, I will submit some requests to fix bugs, etc. Therefore, I plan to cancel this request.

Thank you again for your feedback.

Best Regards,
Jason

@JasonQWJ JasonQWJ closed this Apr 6, 2024
@github-actions github-actions bot removed the status:awaiting user response Awaiting a response from the author label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants