Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweaks to JAX Gemma docs #290

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Minor tweaks to JAX Gemma docs #290

merged 2 commits into from
Mar 15, 2024

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Mar 7, 2024 •
edited
Loading

@pcoet @markmcd @MarkDaoust PTAL

  • In Fine-tuning notebook - under "Learn more" -> use "modules" instead of "methods".
  • Add a link to gemma.params.load_and_format.
  • Add a missing number ("2. Set environment variables") in the "Setup" section.
  • Gemma transformer -> Gemma Transformer (class).
  • Fix a missing ).

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@8bitmp3 8bitmp3 marked this pull request as ready for review March 7, 2024 01:06
@8bitmp3 8bitmp3 requested a review from a team as a code owner March 7, 2024 01:06
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Mar 7, 2024
@markmcd markmcd merged commit 4b2cbf8 into google:main Mar 15, 2024
5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:documentation Update docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8bitmp3 @markmcd