-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react_gemini_prompting.ipynb #255
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good.
Please:
- Setup the code to print the wikipedia URLs everywhere we print wikipedia text
- Where we print the final answer, list all the wikipedia URLs that were used.
- Check for citations (on the
Candidate
) in the response from gemini. - Include the wikipedia license at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the licensing at the top, as we discussed.
Thank you for the review.
If you have used/derived something sourced from an MIT licensed repository I'll consult with the OSS team as suggested. |
Hi, Also, @MarkDaoust, as you have access to that email thread, can you please review if the changes are inline with the team's advice? Thank you. |
I made a few fixes, and couldn't push direct to this brach, can you merge: mayureshagashe2105#1 Also: It's hard to find an example where this approach works. |
@MarkDaoust I have updated the outputs as discussed. Thanks! |
I think this is good to go! |
Looks good - I fixed a few tiny nits. Nice work sneaking a PJO reference in there too 👀 |
Description of the change
Adds react_gemini_prompting.ipynb to demonstrate the
ReAct
prompting method with Gemini. This notebook is a minimal implementation of Yao, S. et alType of change
Choose one: Documentation
Checklist
git pull --rebase upstream main
).