Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react_gemini_prompting.ipynb #255

Merged
merged 24 commits into from
Mar 15, 2024
Merged

Conversation

mayureshagashe2105
Copy link
Contributor

Description of the change

Adds react_gemini_prompting.ipynb to demonstrate the ReAct prompting method with Gemini. This notebook is a minimal implementation of Yao, S. et al

Type of change

Choose one: Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@mayureshagashe2105 mayureshagashe2105 requested a review from a team as a code owner February 7, 2024 07:50
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels Feb 7, 2024
@mayureshagashe2105 mayureshagashe2105 marked this pull request as draft February 7, 2024 17:52
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.

Please:

  1. Setup the code to print the wikipedia URLs everywhere we print wikipedia text
  2. Where we print the final answer, list all the wikipedia URLs that were used.
  3. Check for citations (on the Candidate ) in the response from gemini.
  4. Include the wikipedia license at the top.

@mayureshagashe2105 mayureshagashe2105 marked this pull request as ready for review February 9, 2024 03:10
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the licensing at the top, as we discussed.

site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Outdated Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
site/en/docs/react_gemini_prompting.ipynb Show resolved Hide resolved
Copy link
Contributor Author

Thank you for the review.

If you have used/derived something sourced from an MIT licensed repository

I'll consult with the OSS team as suggested.

@mayureshagashe2105
Copy link
Contributor Author

Hi,
@markmcd after consulting with the OSS team, I have made necessary changes.

Also, @MarkDaoust, as you have access to that email thread, can you please review if the changes are inline with the team's advice?

Thank you.

@MarkDaoust
Copy link
Member

I made a few fixes, and couldn't push direct to this brach, can you merge: mayureshagashe2105#1

Also: It's hard to find an example where this approach works.

@mayureshagashe2105
Copy link
Contributor Author

@MarkDaoust I have updated the outputs as discussed. Thanks!

@mayureshagashe2105
Copy link
Contributor Author

I think this is good to go!
@MarkDaoust

@markmcd
Copy link
Member

markmcd commented Mar 15, 2024

Looks good - I fixed a few tiny nits. Nice work sneaking a PJO reference in there too 👀

@markmcd markmcd merged commit c05a8c6 into google:main Mar 15, 2024
4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants