Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added embedding example #224

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

pcoet
Copy link
Contributor

@pcoet pcoet commented Jan 16, 2024

Description of the change

Adding one more example to the LangChain.js node quickstart: Embedding text.

Motivation

This is a common use case and belongs in the quickstart.

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other): Feature request

Checklist

  • [ x] I have performed a self-review of my code.
  • [ x] I have added detailed comments to my code where applicable.
  • [ x] I have verified that my change does not break existing code.
  • [ x] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [ x] I am familiar with the Google Style Guide for the language I have coded in.
  • [ x] I have read through the Contributing Guide and signed the Contributor License Agreement.

@pcoet pcoet requested a review from a team as a code owner January 16, 2024 20:35
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Jan 16, 2024
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks totally reasonable, but I haven't tested.

@pcoet pcoet merged commit 454b9d0 into google:main Jan 17, 2024
3 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 17, 2024
@pcoet pcoet deleted the langchain-node-embed-text branch January 17, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants