Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pannel with modern spelling panel #205

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Replace pannel with modern spelling panel #205

merged 5 commits into from
Jan 11, 2024

Conversation

nafSadh
Copy link
Contributor

@nafSadh nafSadh commented Dec 24, 2023 •
edited
Loading

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@nafSadh nafSadh requested a review from a team as a code owner December 24, 2023 08:38
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Dec 24, 2023
markmcd
markmcd approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Especially for running nbfmt. Because it's such a good idea I've added it to the GH PR workflow for the templates/ directory too, but that means you'll need to rebase this change, sorry.

MarkDaoust
MarkDaoust requested changes Jan 11, 2024
View reviewed changes
templates/aistudio_gemini_prompt_chat.ipynb Outdated Show resolved Hide resolved
templates/aistudio_gemini_prompt_chat.ipynb Outdated Show resolved Hide resolved
@MarkDaoust MarkDaoust merged commit e38d7cf into google:main Jan 11, 2024
4 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 11, 2024
@nafSadh
Copy link
Contributor Author

nafSadh commented Jan 16, 2024

Sorry didn't follow up here. Looks like Mark synced and merged it in. Thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nafSadh @markmcd @MarkDaoust