matdbg: enable source formatting #8338
Merged
+137
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
force-pushed
the
pf/matdbg-format
branch
2 times, most recently
from
48a7263 to
2f7fc3c
Compare
z3moon
approved these changes
Jan 6, 2025
| "MaxEmptyLinesToKeep: 2" | ||
| "}'"; | ||
|
|
||
| fp = popen(("clang-format " + CLANG_FORMAT_OPTIONS + "< " + TMP_FILENAME).c_str(), "r"); |
There was a problem hiding this comment.
nit: if you use a pipe, I think you don't need to create a temporary file so a bit more efficient.
e.g., echo "int main() {return 0;}" | clang-format -style=Google
but this already looks good, so I'll leave it up to your decision.
There was a problem hiding this comment.
noted. I couldn't find a read-write way to do popen and also didn't want to deal with any kind of escaping of strings.
We use clang-format to format the shader files. Since we assume clang is necessary for compilation, installing clang-format should not be too much of an overhead in terms of adding dependency. Currently, we only support posix systems (macOS, linux).
poweifeng
force-pushed
the
pf/matdbg-format
branch
from
2f7fc3c to
43d211a
Compare
pixelflinger
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use clang-format to format the shader files. Since we assume clang is necessary for compilation, installing clang-format should not be too much of an overhead in terms of adding dependency.
Currently, we only support posix systems (macOS, linux).