Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : null pointer crash #8326

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Fix : null pointer crash #8326

merged 2 commits into from
Dec 30, 2024

Conversation

seker
Copy link
Contributor

@seker seker commented Dec 23, 2024

the 'target_node' of Animation Channel may be nullpointer.

@seker
Copy link
Contributor Author

seker commented Dec 23, 2024

For example:

"animations": [
    {
        "channels": [
            {
                "sampler": 0,
                "target": {
                    "extensions": {
                        "KHR_animation_pointer": {
                            "pointer": "/materials/65/emissiveFactor"
                        }
                    },
                    "path": "pointer"
                }
            },
            {
                "sampler": 1,
                "target": {
                    "extensions": {
                        "KHR_animation_pointer": {
                            "pointer": "/materials/43/emissiveFactor"
                        }
                    },
                    "path": "pointer"
                }
            }
        ],

@seker
Copy link
Contributor Author

seker commented Dec 30, 2024

Any maintainer trigger the workflows please?

@seker
Copy link
Contributor Author

seker commented Dec 30, 2024

I add release notes log, please trigger workflows again.

@bejado bejado merged commit 8c1e028 into google:main Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants