decoding meshoptimized gltf just once #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
reviewed
Aug 21, 2024
| @@ -527,11 +527,11 @@ bool AssetLoaderExtended::createPrimitive(Input* input, Output* out, | |||
|
|
|||
| if (!mCgltfBuffersLoaded) { | |||
| mCgltfBuffersLoaded = utility::loadCgltfBuffers(gltf, mGltfPath.c_str(), mUriDataCache); | |||
| utility::decodeMeshoptCompression(gltf); | |||
There was a problem hiding this comment.
What if this function is called with a different input->gltf?
There was a problem hiding this comment.
that would be true for line 529 too right? this function is called from only one place, at-least with the current implementation, FAssetLoader::createPrimitives which passes the gltf from root asset.
May be do both loadCgltfBuffers & decodeMeshoptCompression at the calling site (FAssetLoader::createPrimitives) similar to ResourceLoader::loadResources?
There was a problem hiding this comment.
yeah, I need to look at this closer I think. For now, this patch is good to go.
Co-authored-by: Powei Feng <[email protected]>
poweifeng
approved these changes
Aug 21, 2024
pixelflinger
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoding the mesh optimized gltf in a loop slows down the extended algo drastically & crashes the app with larger primitives