Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tagging driver handles with a name #8038

Merged
merged 17 commits into from
Aug 24, 2024
Merged

Support tagging driver handles with a name #8038

merged 17 commits into from
Aug 24, 2024

Conversation

bejado
Copy link
Member

@bejado bejado commented Aug 12, 2024 •
edited
Loading

BUGS=[349683761]

@bejado bejado requested a review from pixelflinger August 12, 2024 20:18
@google google deleted a comment from github-actions bot Aug 14, 2024
@bejado bejado marked this pull request as ready for review August 14, 2024 22:35
pixelflinger
pixelflinger requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to factorize the implementation of name() somehow. I don't like having this code repeated so many times.

pixelflinger
pixelflinger requested changes Aug 21, 2024
View reviewed changes
filament/include/filament/FilamentAPI.h Outdated Show resolved Hide resolved
filament/include/filament/FilamentAPI.h Outdated Show resolved Hide resolved
filament/src/FilamentAPI-impl.h Outdated Show resolved Hide resolved
@bejado bejado requested a review from pixelflinger August 22, 2024 16:50
pixelflinger
pixelflinger requested changes Aug 23, 2024
View reviewed changes
filament/include/filament/Texture.h Outdated Show resolved Hide resolved
filament/include/filament/FilamentAPI.h Outdated Show resolved Hide resolved
filament/src/FilamentBuilder.cpp Outdated Show resolved Hide resolved
@bejado bejado merged commit 6f20cf4 into main Aug 24, 2024
11 checks passed
@bejado bejado deleted the bjd/debug-tag branch August 24, 2024 16:17
bejado added a commit that referenced this pull request Aug 24, 2024
@bejado
Support tagging driver handles with a name (#8038)
40ce15c
mbalajee pushed a commit to Fieldwire/filament that referenced this pull request Aug 26, 2024
@bejado @mbalajee
Support tagging driver handles with a name (google#8038)
35ceb53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger pixelflinger requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bejado @pixelflinger