wip: new descriptor set backend API #7737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
0f1de27 to
80a3519
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
2 times, most recently
from
5979024 to
6353291
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
2 times, most recently
from
1fe426e to
ec90035
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
ec90035 to
3264e1d
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
2 times, most recently
from
2c066d9 to
79a7528
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
5 times, most recently
from
62da111 to
391cbcf
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
5 times, most recently
from
5900c24 to
5404f8a
Compare
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
2282c08 to
9c46dcc
Compare
pixelflinger
commented
Jun 10, 2024
filament/backend/src/vulkan/caching/VulkanDescriptorSetManager.cpp
Outdated
Show resolved
Hide resolved
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
9c46dcc to
96b4b0f
Compare
the per-view descriptor-set layout depends on both the material and the variant.
pixelflinger
force-pushed
the
ma/descriptor-sets
branch
from
96b4b0f to
38a3c52
Compare
this test is no important for now, since we don't have a finished compute api. the test breaks because it still use the old non-descriptor based API.
The sizing of each field in Bitmask has changed, and the description was no longer accurate. This caused msan to fail because the mask is also used as a key to cache.
Set postprocess descriptor set for color grading
Using bitset enables simpler counting of bits and the use of the handy 'forEachSetBit'. Also cleaned up various unused code.
DescriptorSetManager's commit() is the inner most of the rendering loop. We want to avoid any hash map look up here. We just store a pointer to the history object where appropriate.
|
see ma/descriptor-sets-1.54.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.