fix: shareable procedures v11 #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2164
Proposed Changes + Reasons
Updates the shareable procedures plugin to be compatible with v11. Updates references to inputs, and procedure hooks.
Test Coverage
Manually tested.
Documentation
N/A - Should be no user-facing change in behavior.
Additional Information
Previously procedures were serialized by procedure serializers in core, but we found that it took too much effort to register new procedure serializers when you were defining new procedure models, so now we've bundled the procedure serialization with the procedure models themselves.
Parameter models are serialized separately by the core procedure serializer and the state is appended to the procedure model state so that procedure models don't have to be tightly coupled to their parameter model classes.