Update ci.yml to run tests with gcov build #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable third party tests in build-gcov similar to what is done in build-llvm. Currently no tests will run for build-gcov, this is in preparation for adding some tests.
|
@snehasish PTAL |
Merged
|
Thanks for taking a look. I also tried an alternative by just tweaking the test invocation in #225. Instead of removing the CMake files, I used |
|
I'd like to be consistent with what we do for llvm. We exclude these third party tests there, so I think we should do the same for gcov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable third party tests in build-gcov similar to what is done in build-llvm.
Currently no tests will run for build-gcov, this is in preparation for adding some tests.