Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Yosys back to 0.29 as workaround for Nexus flow (Yosys #4081). #810

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

tcal-x
Copy link
Collaborator

@tcal-x tcal-x commented Jan 10, 2024

Workaround for YosysHQ/yosys#4081.

This issue is specific to the Lattice Nexus flow.

With current Yosys, the synthesized netlist from synth_nexus contains an explicit 1'b0 driving the low order CIN of a chain of CCU2 (carry chain) primitives. This causes a nextpnr-nexus error. nextpnr-nexus expects this input to be undriven which I assume implies an implicit 1'b0 input.

@tcal-x
Copy link
Collaborator Author

tcal-x commented Jan 11, 2024

Hi @PiotrZierhoffer! I still seem to be seeing intermittent certificate issues with dl.antmicro.com. I could probably get it to green if I could selectively rerun the failing test(s), but unfortunately I don't have the permission to do so.

@tcal-x tcal-x marked this pull request as ready for review January 12, 2024 05:47
@tcal-x tcal-x requested a review from proppy January 12, 2024 05:57
@proppy
Copy link
Member

proppy commented Mar 21, 2024

This causes a nextpnr-nexus error. nextpnr-nexus expects this input to be undriven which I assume implies an implicit 1'b0 input.

I'm curious why this error is not showing up in the CI, are we missing some tests?
https://github.com/google/CFU-Playground/actions/runs/7270368055

@tcal-x
Copy link
Collaborator Author

tcal-x commented Mar 21, 2024

I'm not sure where that link is from, but test-projects.yml is just one of the CI tests; it only runs Renode simulation and doesn't run synth / place / route for any platforms, so it doesn't encounter the issue here. Only the oxide-ci test in oxide.yml and other tests building bitstreams for the Nexus FPGA will encounter the issue.

@proppy
Copy link
Member

proppy commented Mar 21, 2024

Looks like https://github.com/google/CFU-Playground/actions/workflows/oxide.yml?query=branch%3Amain++ was never ran on main, do we have a existing run of this job failing? (or can you share instruction to reproduce this locally? is that similar to #808 and #803?)

@tcal-x
Copy link
Collaborator Author

tcal-x commented Mar 21, 2024

Here is a run from the semi-automatic Renode update, from within the last 24hrs -- it is failing on the issue that's fixed by this PR (CCU2):

https://github.com/google/CFU-Playground/actions/runs/8368656346/job/22913100078

image

@tcal-x
Copy link
Collaborator Author

tcal-x commented Mar 21, 2024

But I agree, the CI runs could use a review and reorg, to make it easier to find the ongoing failures.

@tcal-x
Copy link
Collaborator Author

tcal-x commented Mar 29, 2024

But I agree, the CI runs could use a review and reorg, to make it easier to find the ongoing failures.

I wasn't planning on doing that in this PR though, @proppy.

@proppy
Copy link
Member

proppy commented Mar 29, 2024

Makes sense, I just wanted a way to check that it's indeed fixing the issue:

@proppy proppy merged commit 0612528 into google:main Mar 29, 2024
232 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants