Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor embedding model name in call #645

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Surya2k1
Copy link
Contributor

@Surya2k1 Surya2k1 commented Dec 1, 2024

Description of the change

Embedding model requires to mention as "models/<model_name>" but not other generative models which is simply "<model_name>"

Motivation

It just for consistency of model usage. May fix #640.

Type of change

Feature request

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 1, 2024
@Surya2k1
Copy link
Contributor Author

CC: @MarkDaoust

@MarkDaoust MarkDaoust merged commit 362e001 into google-gemini:main Jan 21, 2025
2 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants