Remove build_circular_geometry defaults. There should be a single source of truth for these defaults, which is the CircularConfig Pydantic model.
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731272969
branch
6 times, most recently
from
c588818 to
e2e7bd4
Compare
…ource of truth for these defaults, which is the `CircularConfig` Pydantic model. Removing defaults breaks many tests, so a general switch is made to using the Pydantic model to build circular geometries instead of `build_circular_geometry`. Includes some fixes in tests for Rmax < Rmin which failed pydantic validation. PiperOrigin-RevId: 731704060
copybara-service
bot
force-pushed
the
test_731272969
branch
from
e2e7bd4 to
72bbf2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
build_circular_geometrydefaults. There should be a single source of truth for these defaults, which is theCircularConfigPydantic model.Removing defaults breaks many tests, so a general switch is made to using the Pydantic model to build circular geometries instead of
build_circular_geometry.Includes some fixes in tests for Rmax < Rmin which failed pydantic validation.