Create Pydantic geometry model. #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_726053298
branch
4 times, most recently
from
8463668 to
32101c4
Compare
There is currently a major duplication of defaults: they are defined in as defaults to functions like `from_fbt_single_slice`. These defaults should eventually be removed. Much of the model validation is currently done via building the provider. This should all be moved into the model validator. PiperOrigin-RevId: 731376444
copybara-service
bot
force-pushed
the
test_726053298
branch
from
32101c4 to
8b1bd4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Pydantic geometry model.
There is currently a major duplication of defaults: they are defined in as defaults to functions like
from_fbt_single_slice. These defaults should eventually be removed.Much of the model validation is currently done via building the provider. This should all be moved into the model validator.