Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: MSF-25904 Using C9S and java 8 for LCM Bricks #1951

Closed
wants to merge 1 commit into from
Closed

BUGFIX: MSF-25904 Using C9S and java 8 for LCM Bricks #1951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
FROM 020413372491.dkr.ecr.us-east-1.amazonaws.com/tools/gdc-java-11-jre-centos9:202310031054.5119496
FROM 020413372491.dkr.ecr.us-east-1.amazonaws.com/tools/gdc-java-8-jdk-centos9:202311071405.4d8c665

ARG RVM_VERSION=stable
ARG JRUBY_VERSION=9.4.1.0

LABEL image_name="GDC LCM Bricks"
LABEL maintainer="LCM <[email protected]>"
LABEL git_repository_url="https://github.com/gooddata/gooddata-ruby/"
LABEL parent_image="020413372491.dkr.ecr.us-east-1.amazonaws.com/tools/gdc-java-11-jre-centos9:202310031054.5119496"
LABEL parent_image="020413372491.dkr.ecr.us-east-1.amazonaws.com/tools/gdc-java-8-jdk-centos9:202311071405.4d8c665"

# which is required by RVM
RUN yum install -y which patch make git maven procps \
Expand All @@ -33,6 +33,13 @@ RUN rvm install jruby-${JRUBY_VERSION} && gem update --system \
&& gem install bundler -v 2.4.6 \
&& gem install rake -v 13.0.6

RUN alternatives --install /usr/bin/java java /usr/lib/jvm/java-1.8.0-openjdk/bin/java 1
RUN update-alternatives --set java java-1.8.0-openjdk.x86_64
#RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk

Copy link
Contributor

@tqtu tqtu Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encounter some errors when using these commands in the barebone images:

sh-5.1# alternatives --install /usr/bin/java java /usr/lib/jvm/java-1.8.0-openjdk/bin/java 1
sh-5.1# update-alternatives --set java /usr/lib/jvm/java-1.8.0-openjdk/bin/java
sh-5.1# export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk
sh-5.1# java
sh: java: command not found
sh-5.1# keytool
sh: keytool: command not found
sh-5.1#

Please consider if the LCM ruby will have the same errors.

#RUN update-alternatives --set java /usr/lib/jvm/java-1.8.0-openjdk/bin/java
#RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk

WORKDIR /src

RUN groupadd -g 48 apache \
Expand Down
6 changes: 6 additions & 0 deletions bin/run_brick.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ def handle_error(params, log, brick_type, error, error_message)
params['GDC_EXECUTION_RESULT_LOG_PATH'] = execution_result_log_path

log.info "action=#{brick_type}_execution status=start commit_hash=#{commit_hash} execution_id=#{execution_id}"

# Start sleep to investigate issue no suitable driver found
log.info "action=#{brick_type}_execution status=start commit_hash=#{commit_hash} execution_id=#{execution_id} sleep=start"
sleep(60)
log.info "action=#{brick_type}_execution status=start commit_hash=#{commit_hash} execution_id=#{execution_id} sleep=end"

brick_pipeline.call(params)
rescue GoodData::LcmExecutionError => lcm_error
handle_error(execution_result_log_params, log, brick_type, lcm_error, lcm_error.summary_error)
Expand Down