Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move demand/proposal retrieval into more sensible location #122

Merged
merged 3 commits into from
Nov 29, 2023
Merged

move demand/proposal retrieval into more sensible location #122

merged 3 commits into from
Nov 29, 2023

Conversation

shadeofblue
Copy link
Contributor

  • work context helpers

@shadeofblue shadeofblue self-assigned this Nov 28, 2023
lucekdudek
lucekdudek suggested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@lucekdudek lucekdudek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like most of the changes. My only concerns are related to changes to WorkContext, please see my comment.

golem/managers/base.py Outdated Show resolved Hide resolved
@shadeofblue shadeofblue merged commit 7fcfbd9 into main Nov 29, 2023
8 of 9 checks passed
@shadeofblue shadeofblue deleted the blue/resource-helpers branch November 29, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucekdudek lucekdudek lucekdudek approved these changes

@approxit approxit Awaiting requested review from approxit

Assignees

@shadeofblue shadeofblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadeofblue @lucekdudek