Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme magnolia-free-hugo-theme #485

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

ololiuhqui
Copy link
Contributor

@ololiuhqui ololiuhqui commented Aug 14, 2024

After you have read the instructions for adding a theme, please make sure:

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit 5f572b2
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/66bcbf55f9cb72000864036b
😎 Deploy Preview https://deploy-preview-485--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid hugo-sid merged commit f9d6d93 into gohugoio:main Aug 19, 2024
4 checks passed
@ololiuhqui
Copy link
Contributor Author

Hi @hugo-sid , I saw that my theme got merged into main today, thank you for the effort!

I was wondering why any of the markdown links in my theme isn't showing and I found out #463, but on the official Hugo Themes website I see there are websites which have their links working, for example "PaperMod".

I was wondering if there's a way to be "link approved" or if that just comes from manual checks made by the Hugo theme,

Thank you!

@hugo-sid
Copy link
Member

hugo-sid commented Aug 20, 2024

Hi @ololiuhqui.

There is no such thing as "link approved", nor there is any manual check for displaying links on Hugo themes website.

In case of PaperMod theme, the 'Demo' anchor tag is within an <h1> tag:

<h1 align=center>Hugo PaperMod | <a href="https://adityatelange.github.io/hugo-PaperMod/" rel="nofollow">Demo</a></h1>

Source: https://github.com/adityatelange/hugo-PaperMod/blob/58c4841c26325eaa788d9b13e65d5dfc95d9367c/README.md?plain=1#L1

I suppose the existing mechanism for disabling links is not capable of detecting such anchor tags & therefore it appears on the website.

Thank you!

Hope that clarifies your concerns. You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants