Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme archie-solarized #479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add theme archie-solarized #479

wants to merge 2 commits into from

Conversation

hcartiaux
Copy link

This is a fork from Ahtul Archie Theme, it supports a dark and light mode strictly based on the Solarized color scheme and guidelines (for background and content tones). It also adds support for tables of contents.

This theme is only based on the Solarized color palette, no other color is used. I think it makes it ideal for any development oriented blog which includes code or terminal extracts.

I know it's a fork, but I've not seen a single Solarized-based theme listed on themes.hugo.io, so I thought this one would be a valuable addition. I let you decide if it makes sense to accept this PR.

Homework done:

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit 8be9a40
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/66a14bb855a36f0008706e50
😎 Deploy Preview https://deploy-preview-479--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid
Copy link
Member

hugo-sid commented Oct 28, 2024

Hello @hcartiaux.

Thanks for submitting this theme. Your observation regarding themes with the Solarized color palette is accurate. But like you mentioned, I wonder whether we can consider this as a new theme all together. Based on your assessment of the changes in your fork, I suggest two options.

Option 1

If the color palette is the only difference from the original theme, consider submitting a PR to the upstream repository to add it.

Option 2

If your fork has notably different features than the original theme, then you may list few arguments in the readme regarding how your fork is different, in which case it can be a candidate for a new theme.

Thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants