-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theme Landing Page Builder #423
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for hugothemes failed.
|
Hey! The path to the image in your README.md is relative, which means it won't be displayed at themes.gohugo.io. Please consider making the path absolute :) |
You might also want to so at https://github.com/HugoBlox/theme-academic-cv. |
8908fac
to
5105071
Compare
@hugo-sid we've updated the Readme with absolute image path as requested. Hope it's all good to proceed with merge now? Thanks :) |
We have clearly stated in the README that:
Your theme seems to be doing exactly this. We will not be able to add your theme in this case. Thank you for your understanding. |
@bep @hugo-sid Please clarify why you are banning open source projects from being listed on the Hugo Themes site? The purpose of the GitHub Readme is to market and promote the open source project... It's common for Hugo Themes on Hugo Themes Site to allow for donations/sponsorships, in fact the Hugo repo itself offers the ability to sponsor Bep - what is your issue with this? Other themes you have added also allow for donations, so why are you singling this theme out as not allowed that? What other marketing campaign are you referring to? |
Thank you for volunteering to manage this project's issue and PR queue. It's a thankless job, and I appreciate your efforts. Serving as a gatekeeper is never easy, requiring thick skin, particularly when you are performing these duties without compensation. Having said that, in this case I would respectfully ask you to reconsider your assessment. I think the primary goal of this aspect of the acceptance criteria is to prevent "bait-and-switch" behavior. Although the Landing Page Builder README could benefit from some clarification1, it is not a bait-and-switch proposition. Thanks in advance for your consideration. Footnotes
|
Thanks for your understanding. Let me clarify.
I never said that donations/sponsorships links are creating problem. They are perfectly fine.
The readme of the theme (& other parts such as repository description) has several links to I see that there are free themes & paid themes available on that website. |
@jmooring, thank you for your kind words & appreciation of my efforts.
Thank you for your valuable inputs. Indeed I am reconsidering my assessment. |
That was not the intention, and to me this theme addition looks good. The sentence in question was added to the README to target themes that acted as promotional banners for commercial theme sites. Financing the theme development work via GitHub sponsors is a different story. |
Thanks for your inputs @bep.
There is no doubt about that. This is a great theme.
IMHO, this theme has several links to commercial theme site Perhaps "promotional banners" is a grey area we need to sort out. It would be great, if we can clearly define what constitutes violation of that rule (or what is considered as promotional banner). Are we saying that:
I came across a theme https://github.com/zerostaticthemes/hugo-whisper-theme?tab=readme-ov-file#credits (presently listed on Pardon me if I have overlooked some things or missed out something which may seem obvious. Please don't be under the impression that I am adamant not to include this theme. I am just trying to seek more clarity regarding this rule. I believe this will help ensure compliance and avoid any future misunderstandings (whenever such cases come up). Thank you for your patience and assistance. |
OK, I didn't see that. Then I (we) need to think about this some more. I will get back after some thinking, lets just leave this PR/issue open for now. |
This is the website for the open source project here: https://github.com/HugoBlox/hugo-blox-builder The website enables users who value the templates to donate via GitHub Sponsors or LemonSqueezey to support further development of the open source project and be rewarded with some perks for doing so, just like if I sponsor Bep, Bep may kindly send some Hugo stickers. So if donations are considered 'commercial' and disallowed, I guess we should also remove all the other themes on here which have a link to sponsor the creator/maintainer so that each theme is assessed fairly and there's no bias? |
Can we please arrive at a consensus Should our goal be to:
|
Add theme Landing Page Builder