feat: allow for configuring the docker hub registry endpoint via API #21385
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
This PR adds the possibility to change the registry endpoint of DockerHub via API. This is useful for Harbor instances that run in airgapped environments and have to go through a DMZ or use a reverse proxy to access DockerHub.
Why not just use a normal Docker Registry type instead of the DockerHub adapter?
Because of the logic for
library
images which only applies to the Registry Type DockerHub:harbor/src/server/middleware/repoproxy/proxy.go
Lines 128 to 144 in 8bf710a
By allowing to change the registry endpoint for DockerHub, those kinds of environments can still benefit from the
library
substitution logic.Please indicate you've done the following: