-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to configure connMaxLifetime and connMaxIdleTime. #1768
Open
Vad1mo
wants to merge
13
commits into
goharbor:main
Choose a base branch
from
container-registry:contrib/db-connection-lifecycle-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add option to configure connMaxLifetime and connMaxIdleTime. #1768
Vad1mo
wants to merge
13
commits into
goharbor:main
from
container-registry:contrib/db-connection-lifecycle-options
+383
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyyw
reviewed
Jun 13, 2024
@Vad1mo could you please help to resolve the conflicts? Thanks |
zyyw
approved these changes
Jun 18, 2024
Vad1mo
force-pushed
the
contrib/db-connection-lifecycle-options
branch
from
July 28, 2024 12:02
e816832
to
16f0449
Compare
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Signed-off-by: yminer <[email protected]>
This reverts commit b0c90f7. Signed-off-by: yminer <[email protected]>
Revert "add helper for overrides namespace while using helm template"
Signed-off-by: yminer <[email protected]>
Bump version to 1.16.0, appVersion to 2.12.0
Signed-off-by: yminer <[email protected]>
fix typo in values.yaml
Signed-off-by: yminer <[email protected]> Co-authored-by: yminer <[email protected]>
Signed-off-by: yminer <[email protected]> Co-authored-by: yminer <[email protected]>
Signed-off-by: yminer <[email protected]>
Signed-off-by: yminer <[email protected]>
Signed-off-by: Vadim Bauer <[email protected]> # Conflicts: # templates/exporter/exporter-cm-env.yaml
…this is the default in values.yaml Signed-off-by: Vadim Bauer <[email protected]>
Vad1mo
force-pushed
the
contrib/db-connection-lifecycle-options
branch
from
January 20, 2025 09:47
6d2a1bf
to
587003f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to set Postgres connMaxLifetime and connMaxIdleTime on harbor core and with an override option on harbor exporter.