Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: os/gcron: unit testing case of package gcron occasionally failed #4129

Closed

Conversation

wanghaolonggit
Copy link

@gqcn
Copy link
Member

gqcn commented Jan 22, 2025

@wanghaolonggit 你好,感谢参与开源共建。这里针对定时任务的修复不应当通过额外的锁机制来保证执行完毕,应该根据日志的打印时间来判断为什么单测不满足断言条件,根据排查的结果,可能需要对定时任务或者单测逻辑进行改进。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@wanghaolonggit Hello, thank you for participating in open source co-construction. The repair of scheduled tasks here should not use additional lock mechanisms to ensure completion of execution. The printing time of the log should be used to determine why the single test does not meet the assertion conditions. Based on the results of the investigation, the scheduled tasks or single test logic may need to be improved. .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants