Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to app version 2.9.6 #50

Merged
merged 4 commits into from
Mar 28, 2024
Merged

chore: Update to app version 2.9.6 #50

merged 4 commits into from
Mar 28, 2024

Conversation

mkilchhofer
Copy link
Collaborator

No description provided.

@mkilchhofer mkilchhofer requested a review from p53 March 26, 2024 09:29
@mkilchhofer mkilchhofer marked this pull request as draft March 26, 2024 16:34
@p53
Copy link
Contributor

p53 commented Mar 28, 2024

@mkilchhofer thanks! could you update –openid-provider-timeout value to e.g. 120s, seems tests are failing

@mkilchhofer
Copy link
Collaborator Author

mkilchhofer commented Mar 28, 2024

@mkilchhofer thanks! could you update –openid-provider-timeout value to e.g. 120s, seems tests are failing

It seems that the keycloak image does not exist anymore:

$ kind create cluster
Creating cluster "kind" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
Set kubectl context to "kind-kind"
You can now use your cluster with:

kubectl cluster-info --context kind-kind

Have a question, bug, or feature request? Let us know! https://kind.sigs.k8s.io/#community

$ kubectl apply -f .github/manifest.yaml
configmap/keycloak-config created
configmap/mock-config created
deployment.apps/mock created
deployment.apps/keycloak created
service/mock created
service/keycloak created
ingress.networking.k8s.io/nginx created

$ kubectl rollout status deployment/keycloak
Waiting for deployment "keycloak" rollout to finish: 0 of 1 updated replicas are available...

$ kubectl get po
NAME                        READY   STATUS         RESTARTS   AGE
keycloak-56f5876876-zzncm   0/1     ErrImagePull   0          72s
mock-6d6fdcd98c-zwq6m       1/1     Running        0          72s

$ kubectl get events
LAST SEEN   TYPE      REASON                    OBJECT                           MESSAGE
81s         Normal    Scheduled                 pod/keycloak-56f5876876-zzncm    Successfully assigned default/keycloak-56f5876876-zzncm to kind-control-plane
29s         Normal    Pulling                   pod/keycloak-56f5876876-zzncm    Pulling image "jboss/keycloak:16.1.1"
29s         Warning   Failed                    pod/keycloak-56f5876876-zzncm    Failed to pull image "jboss/keycloak:16.1.1": rpc error: code = Unknown desc = failed to pull and unpack image "docker.io/jboss/keycloak:16.1.1": failed to resolve reference "docker.io/jboss/keycloak:16.1.1": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
29s         Warning   Failed                    pod/keycloak-56f5876876-zzncm    Error: ErrImagePull

Does it really needs to be keycloak or can we try to use an existing OIDC provider (e.g. OpenID Connect Playground) or even a mock provider like https://github.com/Soluto/oidc-server-mock ?

@p53
Copy link
Contributor

p53 commented Mar 28, 2024

@mkilchhofer ah ok checked logs just briefly, so lets update it to latest keycloak, we cannot use oidc server mock because gatekeeper checks at start structure of OIDC server url and whether it is keycloak specific url (i am working on separate gatekeeper oidc proxy or base proxy which would not have keycloak specific functionalities, rewrote several things to be able to reuse components between them but still not yet there)

@mkilchhofer
Copy link
Collaborator Author

mkilchhofer commented Mar 28, 2024

Ah maybe we can just change the url to quay.io/keycloak/keycloak:16.1.1 and update the keycloak in a later step?

@mkilchhofer mkilchhofer marked this pull request as ready for review March 28, 2024 12:13
@p53 p53 merged commit 05bb957 into main Mar 28, 2024
1 check passed
@p53
Copy link
Contributor

p53 commented Mar 28, 2024

FYI, i am already using keycloak 19 in E2E tests and i would like to update it soon to latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants