Add Workshop package #984
Add Workshop package #984
Conversation
…on' into add-registry
There was a problem hiding this comment.
Removed some stale config settings, me and @brandonfancher will go over the rest and figure out what makes sense and update all Vite projects.
There was a problem hiding this comment.
Yeah. I think we're going to need to do the opposite of what we've been doing. Instead of proxying from the vite dev server, we may want to proxy from the psibase config to the dev server for certain subdomains. Otherwise, our same-origin cross-subdomain OAuth-y stuff isn't going to work when trying to iterate quickly via the dev server, as it runs on another port.
James-Mart
added
the
System app
There was a problem hiding this comment.
Let's remove this file and is reference in index.html
There was a problem hiding this comment.
This is boilerplate that can be deleted, right?
| <FormItem> | ||
| <FormLabel>App Name</FormLabel> | ||
| <FormControl> | ||
| <Input placeholder="MonsterApp" {...field} /> |
There was a problem hiding this comment.
I'd recommend a different default example here instead of a game. Maybe something related to voting or trading. Or a prediction market of some kind. 🤔
| <FormItem> | ||
| <FormLabel>Terms of service</FormLabel> | ||
| <FormControl> | ||
| <Input placeholder="/terms-of-service" {...field} /> |
There was a problem hiding this comment.
I was a little confused by the placeholder in these three fields. My initial intuition was that they were defaults that would actually get submitted if I didn't overwrite them. Instead, / was submitted for them.
I could see a couple ways of getting around that:
- Make them required so the user has to explicitly input values, or
- Make the placeholder value submit as the default value, unless overridden by the user
There was a problem hiding this comment.
This reminds me...should there be a dark/light toggle?
This adds the
Workshop.psipackage with it's own UI which engages the registry.Currently, whatever account the user is authenticated as is assumed to be the account of the actual app, after staged transactions is ready we'll later adopt it for a better multi-user experience.
The default header in sites for
Content-Security-Policyin images has been updated to include:dataso that image embedding from a string will work, subsequent changes will remove the idea of default headers and instead will be entirely configurable in the workshop app for developers to work with.