Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt testcontainers-go for Postgres, MySQL and MongoDB #1515

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
4ed3649
chore: use testcontainers-go in mongodb store
mdelapenya Aug 29, 2024
0e060e1
chore: use testcontainers-go in mssql store
mdelapenya Aug 29, 2024
2f17493
chore: use testcontainers-go in mysql store
mdelapenya Aug 29, 2024
2f5263e
chore: use testcontainers-go in postgres store
mdelapenya Aug 29, 2024
689759c
fix: wrong image name for mongo
mdelapenya Aug 29, 2024
ff25433
fix: proper Go version matrix
mdelapenya Aug 29, 2024
fc01fc5
fix: remove toolchain in go mod
mdelapenya Aug 29, 2024
4ad4b03
chor: consistent Go version
mdelapenya Aug 29, 2024
b53f02b
fix: remove toolchain
mdelapenya Aug 29, 2024
de8f798
chore: consistent Go versions matrix
mdelapenya Aug 29, 2024
471a6ac
fix: remove more postgres options
mdelapenya Sep 16, 2024
c80f126
chore: adjust Go matrix versions to use 1.20 as the minimum version
mdelapenya Sep 16, 2024
1d6c0c3
chore: set Go 1.21 for modules
mdelapenya Sep 16, 2024
4d7a172
chore: use Ubuntu 22.04 base image for MSSQL
mdelapenya Sep 18, 2024
75c8525
chore: close store for previous modules
mdelapenya Sep 18, 2024
1bb4d92
chore: close store
mdelapenya Sep 18, 2024
f962d64
chore: terminate container on end
mdelapenya Sep 18, 2024
1c23d53
chore: bump MSSQL image to not crash in the GH workers
mdelapenya Sep 19, 2024
7bbad9a
fix: swap values in mysql constants
mdelapenya Sep 19, 2024
efbc89f
fix: do not close store twice in tests
mdelapenya Sep 19, 2024
153c837
fix: reorder
mdelapenya Sep 19, 2024
43a47ef
fix: do not close twice in mysql test
mdelapenya Sep 19, 2024
3cd89db
fix: terminate second mysql container
mdelapenya Sep 19, 2024
60be628
chore: bump couchbase image
mdelapenya Sep 19, 2024
a4849c8
Revert "fix: terminate second mysql container"
mdelapenya Sep 19, 2024
b3a2e40
chore: bump testcontainers-go to v0.34.0
mdelapenya Oct 23, 2024
db3ab9a
Merge branch 'main' into tc-go-adoption-2
mdelapenya Dec 11, 2024
78da7fc
chore(ci): run modules in Go 1.21 and above
mdelapenya Dec 11, 2024
49eeb1d
chore: add verbose flag to benchmarks
mdelapenya Dec 11, 2024
1a5e6f9
chore: include Go 1.23 for clickhouse tests
mdelapenya Dec 11, 2024
cdf78c2
chore: tune the benchmark worker
mdelapenya Dec 11, 2024
a7a26b8
fix: run with sudo
mdelapenya Dec 11, 2024
39be258
chore: remove tuning
mdelapenya Dec 11, 2024
8ee8130
chore: bump MSSQL image
mdelapenya Dec 11, 2024
bff5333
chore: simplify testing panics
mdelapenya Dec 12, 2024
8cb7bc5
chore: increase sysctl values for the MSSQL container
mdelapenya Dec 12, 2024
15865d5
Revert "chore: increase sysctl values for the MSSQL container"
mdelapenya Dec 12, 2024
4f1577a
fix: use ubuntu-22.04 as GH runner for the benchmarks
mdelapenya Dec 12, 2024
478ea67
Revert "fix: use ubuntu-22.04 as GH runner for the benchmarks"
mdelapenya Dec 12, 2024
b074e83
chore: try MSSQL 2022 latest image
mdelapenya Dec 12, 2024
cac4fd5
chore: use cleanup function
mdelapenya Dec 12, 2024
ae3a2de
chore: revert MSSQL work
mdelapenya Dec 12, 2024
c061165
chor: increase go test timeout
mdelapenya Dec 12, 2024
af52fa3
chore: define timeout for the workflow
mdelapenya Dec 12, 2024
0439f04
Merge branch 'main' into tc-go-adoption-2
mdelapenya Jan 30, 2025
4e4e575
chore: remove mongo from benchmarks
mdelapenya Jan 30, 2025
66cdbbd
chore: remove mysql from benchmarks
mdelapenya Jan 30, 2025
8e75266
chore: remove postgres from benchmarks
mdelapenya Jan 30, 2025
0f88b95
chore: remove MSSQL from benchmarks
mdelapenya Jan 30, 2025
2cc5e2c
fix: wrong Go version
mdelapenya Jan 30, 2025
6742f2a
feat: use testcontainers-go's MSSQL module
mdelapenya Jan 30, 2025
d793dc4
chore: bump testcontainers-go in the S3 module
mdelapenya Jan 30, 2025
3a3ab81
Merge branch 'main' into tc-go-adoption-2
mdelapenya Jan 30, 2025
4c2246e
Revert "feat: use testcontainers-go's MSSQL module"
mdelapenya Jan 30, 2025
c1362f1
chore: bump tc-go to v0.35.0
mdelapenya Jan 30, 2025
a9bb64e
chore: bump tc-go
mdelapenya Jan 30, 2025
d3c0d39
Merge branch 'main' into tc-go-adoption-2
mdelapenya Feb 18, 2025
0c2d884
chore: implement more robust wait strategies in testcontainers services
mdelapenya Feb 18, 2025
c2e5b74
chore: check the key expired
mdelapenya Feb 18, 2025
fe98837
fix: forgot to close mysql store in test
mdelapenya Feb 18, 2025
f2ff5e7
chore: extract ports to constants
mdelapenya Feb 18, 2025
e91a22a
chore: add suggestions from coderabbit
mdelapenya Feb 19, 2025
0f9476e
chore: wait for couchbase's listening port
mdelapenya Feb 19, 2025
5175998
chore: increase benchmarks timeout to 300s
mdelapenya Feb 28, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove MSSQL from benchmarks
mdelapenya committed Jan 30, 2025
commit 0f88b957a8de76b230ceb63dd26174ea21b2f542
14 changes: 0 additions & 14 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
@@ -81,20 +81,6 @@ jobs:
run: |
docker run -d -p 11211:11211 memcached:latest

- name: Install MSSQL
if: ${{ matrix.package == 'mssql' }}
run: |
docker run -d -p 1433:1433 \
-e "ACCEPT_EULA=Y" -e "SA_PASSWORD=MsSql!1234" \
-e "MSSQL_DB=master" -e "MSSQL_USER=sa" \
-e "MSSQL_PASSWORD=MsSql!1234" \
--health-cmd "/opt/mssql-tools/bin/sqlcmd -U sa -P $SA_PASSWORD -Q 'select 1' -b -o /dev/null" \
--health-interval 1s \
--health-timeout 30s \
--health-start-period 10s \
--health-retries 20 \
mcmoe/mssqldocker:latest

- name: Install Azurite
if: ${{ matrix.package == 'azureblob' }}
run: |