[PFX-637] Support create App Router #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpina1-godaddy
changed the title
There was a problem hiding this comment.
Can you update with the latest from my PR that fixed Page Router rendering.
There was a problem hiding this comment.
mmason2-godaddy
approved these changes
Jun 6, 2024
|
|
||
| export default function RootLayout({ children }) { | ||
| return ( | ||
| <html lang='en'> |
There was a problem hiding this comment.
We shouldn't presume lang='en'
There was a problem hiding this comment.
Eslint looks for a lang value here <html> elements must have the lang prop jsx-a11y/html-has-lang.
What would be a good default for this?
Would en be safe for the boilerplate code?
| ]); | ||
|
|
||
| newContext.useAppRouter = useAppRouter; | ||
| newContext.nextServerType = 'defaultServer'; |
There was a problem hiding this comment.
Wouldn't this line get skipped if useAppRouter was already in the context? What would happen if nextServerType was not initialized?
There was a problem hiding this comment.
I added a check outside of the useAppRouter prompt
if (newContext.useAppRouter) {
newContext.nextServerType = 'defaultServer';
}
bbetts-godaddy
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added prompt to use App Router with the Gasket Nextjs plugin.
It does not currently work with Redux. This needs to be addressed in a separate ticket. We also need to port any logic from
_appand_documentfiles in a separate ticket.I also removed the generated test from the cypress plugin. This test was conflicting with the generated cypress test in the nextjs plugin.
Changelog
@gasket/plugin-cypress@gasket/plugin-nextjsTest Plan