Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoTypeSay #5412

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Add NoTypeSay #5412

merged 1 commit into from
Feb 12, 2025

Conversation

salanth357
Copy link
Contributor

No description provided.

@bleatbot bleatbot enabled auto-merge (squash) February 1, 2025 03:00
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 1, 2025

Outdated attempt

This is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you.

Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging.

Please hold!

@reiichi001
Copy link
Contributor

bleatbot, approve

@bleatbot
Copy link
Collaborator

bleatbot commented Feb 1, 2025

Outdated attempt

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ NoTypeSay [testing-live] dad2bd9 v0.0.0.1 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. size-large Diff for this PR is large. labels Feb 1, 2025
@reiichi001 reiichi001 added the completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. label Feb 1, 2025
@philpax
Copy link
Contributor

philpax commented Feb 3, 2025

Apologies for the delay - this plugin is now in the plugin review queue; we hope to get back to you soon!

@philpax philpax added pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. and removed pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. labels Feb 3, 2025
@philpax
Copy link
Contributor

philpax commented Feb 9, 2025

bleatbot, rebuild

@bleatbot
Copy link
Collaborator

bleatbot commented Feb 9, 2025

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ NoTypeSay [testing-live] dad2bd9 v0.0.0.1 - Repo (New plugin)
8 Needs (✅ All reviewed)
Type Name Version Reviewed by
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
7 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot removed the pending-testing This plugin still needs to be tested. label Feb 9, 2025
@philpax philpax added the completed-testing This plugin has been tested. label Feb 12, 2025
@bleatbot bleatbot merged commit fbeba96 into goatcorp:main Feb 12, 2025
2 checks passed
@philpax
Copy link
Contributor

philpax commented Feb 12, 2025

Congratulations on your first plugin added to the main Dalamud plugin repository!

As a first-time contributor, if you're in the XIVLauncher & Dalamud Discord server and would like to get access to the private developer channels for plugin feedback and others, please let us know your Discord handle and we'll grant you the role.

@salanth357 salanth357 deleted the patch-1 branch February 12, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed-code-review Someone reviewed this. Check if the review wasn't invalidated already. completed-rules-compliance This plugin is compliant with all rules. completed-testing This plugin has been tested. new plugin This is a new plugin. size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants