enhance(pagination)!: remove total results calculation for performance improvement #1254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than calculate pagination logic on total count, we can leverage whether or not the current page of results is equal to the per-page setting.
This will create some awkward situations where the total results are a multiple of the per-page setting, but we can handle this in the UI more gracefully (there will need to be a follow up PR in that repo).
However, the awkward handling is worth the performance improvement. Using telemetry, we have been able to discover that the most expensive DB queries in the application are all the counts. They are not necessary for functionality and are notoriously not performant. This change should make almost every list API far more snappy.