Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): improved messaging #1243

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(yaml): improved messaging #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/yaml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func ParseYAML(data []byte) (*types.Build, []string, error) {

config = legacyConfig.ToYAML()

warnings = append(warnings, "using legacy version. Upgrade to go-yaml v3")
warnings = append(warnings, `using legacy version - address any incompatibilities and use "1" instead`)

default:
// unmarshal the bytes into the yaml configuration
Expand Down
2 changes: 1 addition & 1 deletion internal/yaml_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func TestInternal_ParseYAML(t *testing.T) {
name: "buildkite legacy",
file: "testdata/buildkite.yml",
wantBuild: wantBuild,
wantWarnings: []string{"using legacy version. Upgrade to go-yaml v3"},
wantWarnings: []string{`using legacy version - address any incompatibilities and use "1" instead`},
},
{
name: "anchor collapse",
Expand Down
Loading