Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: supply parent context to scm funcs #1169
enhance: supply parent context to scm funcs #1169
Changes from all commits
c802e617e4d38a4e09eb90eb020951e4f75bb7849eFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 3 in api/pipeline/validate.go
[golangci] api/pipeline/validate.go#L3
Raw output
api/pipeline/validate.go:3: 3-110 lines are duplicate of `api/pipeline/expand.go:4-112` (dupl) package pipeline import ( "fmt" "net/http" "github.com/gin-gonic/gin" "github.com/sirupsen/logrus" "github.com/go-vela/server/compiler" "github.com/go-vela/server/internal" "github.com/go-vela/server/router/middleware/pipeline" "github.com/go-vela/server/router/middleware/repo" "github.com/go-vela/server/router/middleware/user" "github.com/go-vela/server/util" ) // swagger:operation POST /api/v1/pipelines/{org}/{repo}/{pipeline}/validate pipelines ValidatePipeline // // Get, expand and validate a pipeline // // --- // produces: // - application/yaml // - application/json // parameters: // - in: path // name: org // description: Name of the organization // required: true // type: string // - in: path // name: repo // description: Name of the repository // required: true // type: string // - in: path // name: pipeline // description: Commit SHA for pipeline to retrieve // required: true // type: string // - in: query // name: output // description: Output string for specifying output format // type: string // default: yaml // enum: // - json // - yaml // security: // - ApiKeyAuth: [] // responses: // '200': // description: Successfully retrieved, expanded and validated the pipeline // schema: // type: string // '400': // description: Invalid request payload or path // schema: // "$ref": "#/definitions/Error" // '401': // description: Unauthorized // schema: // "$ref": "#/definitions/Error" // '404': // description: Not found // schema: // "$ref": "#/definitions/Error" // '500': // description: Unexpected server error // schema: // "$ref": "#/definitions/Error" // ValidatePipeline represents the API handler to capture, // expand and validate a pipeline configuration. func ValidatePipeline(c *gin.Context) { // capture middleware values m := c.MustGet("metadata").(*internal.Metadata) l := c.MustGet("logger").(*logrus.Entry) p := pipeline.Retrieve(c) r := repo.Retrieve(c) u := user.Retrieve(c) ctx := c.Request.Context() entry := fmt.Sprintf("%s/%s", r.GetFullName(), p.GetCommit()) l.Debugf("validating pipeline %s", entry) // ensure we use the expected pipeline type when compiling r.SetPipelineType(p.GetType()) // create the compiler object compiler := compiler.FromContext(c).Duplicate().WithCommit(p.GetCommit()).WithMetadata(m).WithRepo(r).WithUser(u) ruleData := prepareRuleData(c) // validate the pipeline pipeline, _, err := compiler.CompileLite(ctx, p.GetData(), ruleData, false) if err != nil { retErr := fmt.Errorf("unable to validate pipeline %s: %w", entry, err) util.HandleError(c, http.StatusBadRequest, retErr) return } writeOutput(c, pipeline) }Check failure on line 78 in api/pipeline/validate.go
[golangci] api/pipeline/validate.go#L78
Raw output
api/pipeline/validate.go:78: 78-110 lines are duplicate of `api/pipeline/compile.go:80-112` (dupl) func ValidatePipeline(c *gin.Context) { // capture middleware values m := c.MustGet("metadata").(*internal.Metadata) l := c.MustGet("logger").(*logrus.Entry) p := pipeline.Retrieve(c) r := repo.Retrieve(c) u := user.Retrieve(c) ctx := c.Request.Context() entry := fmt.Sprintf("%s/%s", r.GetFullName(), p.GetCommit()) l.Debugf("validating pipeline %s", entry) // ensure we use the expected pipeline type when compiling r.SetPipelineType(p.GetType()) // create the compiler object compiler := compiler.FromContext(c).Duplicate().WithCommit(p.GetCommit()).WithMetadata(m).WithRepo(r).WithUser(u) ruleData := prepareRuleData(c) // validate the pipeline pipeline, _, err := compiler.CompileLite(ctx, p.GetData(), ruleData, false) if err != nil { retErr := fmt.Errorf("unable to validate pipeline %s: %w", entry, err) util.HandleError(c, http.StatusBadRequest, retErr) return } writeOutput(c, pipeline) }